[NFC] Change term kMajor to kContig#5679
Merged
Merged
Conversation
antiagainst
requested review from
antiagainst,
ptillet and
zhanglx13
as code owners
Member
|
@lezcano: this is a follow up to #5126 (comment). |
antiagainst
approved these changes
Jan 23, 2025
makslevental
pushed a commit
to makslevental/triton
that referenced
this pull request
Feb 19, 2025
This commit changes terminology for matrices that are contiguous along K dimension in memory. Previously term kMajor is used for such matrices. Since major-minor terminology can be ambiguous this commit switches to using term kContig for K contiguous matrices, which is hopefully more clear. Co-authored-by: Ognjen Plavsic <plognjen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes terminology for matrices that are contiguous along K dimension in memory.
Previously term kMajor is used for such matrices. Since major-minor terminology can be ambiguous
this commit switches to using term kContig for K contiguous matrices, which is hopefully more clear.